https://bugs.kde.org/show_bug.cgi?id=493978
Akseli Lahtinen <akse...@akselmo.dev> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REPORTED |RESOLVED
Latest Commit| |https://invent.kde.org/plas
| |ma/plasma-workspace/-/commi
| |t/08bfc5a3aff369694abfaee9d
| |35f0056b76db113
--- Comment #5 from Akseli Lahtinen <akse...@akselmo.dev> ---
Git commit 08bfc5a3aff369694abfaee9d35f0056b76db113 by Akseli Lahtinen.
Committed on 11/10/2024 at 19:28.
Pushed by akselmo into branch 'master'.
FingerprintDialog: Place ColumnLayout with the stack inside contentItem
This MR has two commits that affect the behavior of the dialog.
* FingerprintDialog: Place ColumnLayout with the stack inside contentItem
Previously we set the implicitSize directly to the dialog. This causes weird
issues since
the stackView can be larger than the dialog. Setting the same values as the
minimum values of
the stackView fixes the issue, since the size of the dialog is calculated
through the stackView
values (since it's the dialogs content). Also fix some widths being applied
into implicitWidth properties.
Requires https://invent.kde.org/frameworks/kirigami/-/merge_requests/1637
Related: bug 493977, bug 493976
* fingerprintmodel.cpp: Fix spamming signals if changing to same value
If any "set" method was called, such as "setDialogState", we
did not check for the previous state and just changed it,
then signaled the change.
This causes the FingerprintDialog StackView to get upset and
show a lot of warnings how it's not done yet.
Only change the state if it's not the same as the previous one to
avoid this issue.
M +19 -11 kcms/users/src/fingerprintmodel.cpp
M +2 -3 kcms/users/src/ui/FingerprintDialog.qml
M +1 -1 kcms/users/src/ui/PickFinger.qml
M +1 -1 kcms/users/src/ui/PicturesSheet.qml
https://invent.kde.org/plasma/plasma-workspace/-/commit/08bfc5a3aff369694abfaee9d35f0056b76db113
--
You are receiving this mail because:
You are watching all bug changes.
