https://bugs.kde.org/show_bug.cgi?id=492221
Igor Kushnir <igor...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/kdev |https://invent.kde.org/kdev
|elop/kdevelop/-/commit/32d3 |elop/kdevelop/-/commit/c7d5
|88680839d22c8d635dc8c63a7a8 |09b5846f24760c6af2dbb5fec8e
|845901e96 |727c5a86a
--- Comment #12 from Igor Kushnir <igor...@gmail.com> ---
Git commit c7d509b5846f24760c6af2dbb5fec8e727c5a86a by Igor Kushnir.
Committed on 04/09/2024 at 17:52.
Pushed by igorkushnir into branch 'release/24.08'.
UsesWidget: don't try to insert items at invalid positions
cb01708424c1b21077761c6259e50fec1fac071f intended to insert
high-priority uses at the top, normal-priority in the middle, and
low-priority ones (declaration/definition-only) at the bottom. But
optionally passing widget->items().size() as the insertion position to
NavigatableWidgetList::addItem() cannot achieve that. Furthermore, the
number of items in `widget` can be greater than the number of items in
the higher-level `m_widget`. In this case KDevelop eventually segfaults
in QBoxLayout::itemAt() since Qt 6, or given a Qt build with assertions
enabled, the "index out of range" assertion fails in
QBoxLayout::insertWidget() => QBoxLayoutPrivate::validateIndex().
Remove the broken and crashing insertion at widget->items().size() and
insert both normal- and low-priority uses at the bottom for now.
FIXED-IN: 6.0.240801
(cherry picked from commit 32d388680839d22c8d635dc8c63a7a8845901e96)
M +6 -1 kdevplatform/language/duchain/navigation/useswidget.cpp
https://invent.kde.org/kdevelop/kdevelop/-/commit/c7d509b5846f24760c6af2dbb5fec8e727c5a86a
--
You are receiving this mail because:
You are watching all bug changes.
