https://bugs.kde.org/show_bug.cgi?id=490924

Fabian Vogt <fab...@ritter-vogt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |NEEDSINFO
         Resolution|---                         |WAITINGFORINFO

--- Comment #4 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Sophie Dexter from comment #3)
> (In reply to Fabian Vogt from comment #1)
> > If the broken PAM conversation is the cause, this should avoid it:
> > 
> > diff --git a/greeter/greeterapp.cpp b/greeter/greeterapp.cpp
> > index eb088cc..6c016cb 100644
> > --- a/greeter/greeterapp.cpp
> > +++ b/greeter/greeterapp.cpp
> > @@ -527,7 +527,6 @@ void UnlockApp::suspendToRam()
> >  
> >      m_ignoreRequests = true;
> >      m_resetRequestIgnoreTimer->start();
> > -    m_authenticators->cancel();
> >  
> >      PowerManagement::instance()->suspend();
> >  }
> Thank you Fabian, I have compiled kscreenlocker_greet with your patch and it
> resolves the rejected password issue for me :-)

Great! Without this patch it should just start another PAM session after waking
up,
when the UI becomes visible again. For some reason that does not work. Maybe
it's some kind of rate limit that gets tripped even beyond suspend/release. In
that
case it would make sense to stop only the noninteractive authenticators. Not
sure
how to find out though.

Another option could be that the authenticator isn't actually started properly
again
after wakeup, as there is no fitting error message in the log.

It would be useful if you could run

QT_LOGGING_RULES=kscreenlocker_greet.debug=true
/usr/libexec/kscreenlocker_greet --testing -platform xcb

and reproduce the issue. It's possible that the log contains some sensitive
information,
so please read through it before uploading.

> > Probably not a proper fix though, at least the noninteractive authenticators
> > running in the background should probably be stopped before suspending.
> > Currently that's not guaranteed either though, it's all async.
> I understand at a very abstract level why you are concerned that this is a
> rough workaround but don't understand in any of the detail.

I don't know all details either - PAM is complex and very temperamental.

> With enough the
> time I'd love to learn one day as I've raised a few bug reports now and have
> graduated to the level of 'can compile with supplied patches' :-D. Until I
> achieve my next badge (or 3) I'll have to leave a proper, or at least
> acceptable, fix to you as professionals. In the mean time I'll watch this
> bug report and test any developments too.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to