https://bugs.kde.org/show_bug.cgi?id=481303

--- Comment #13 from Harald Sitter <sit...@kde.org> ---
Git commit 9188ab187ff428b473c82cd3e13dc85963b04363 by Harald Sitter.
Committed on 22/07/2024 at 06:04.
Pushed by sitter into branch 'Plasma/6.1'.

category: assert names aren't duplicated

this is an implicit requirement of our sorting logic that can break when
categories are non-uniquely translated

specifically it makes no sense to have ambiguous category names on the
same "level", the user isn't able to tell them apart (in particular also
in a a11y context -- e.g. screenreaders). so it makes no sense at all

guard against this with a simplistic test that loads all categories in
all known languages


(cherry picked from commit 40995bd1c41f19f9bba259081ffc11afd3a853cf)

Co-authored-by: Harald Sitter <sit...@kde.org>

M  +18   -5    libdiscover/Category/CategoriesReader.cpp
M  +5    -2    libdiscover/Category/CategoriesReader.h
M  +73   -5    libdiscover/Category/Category.cpp
M  +11   -1    libdiscover/Category/Category.h
M  +27   -1    libdiscover/tests/CategoriesTest.cpp

https://invent.kde.org/plasma/discover/-/commit/9188ab187ff428b473c82cd3e13dc85963b04363

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to