https://bugs.kde.org/show_bug.cgi?id=489745

Aleix Pol <aleix...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/discover/-/commit/101c01
                   |                            |494ede10659740827c63dac874b
                   |                            |f18f121

--- Comment #6 from Aleix Pol <aleix...@kde.org> ---
Git commit 101c01494ede10659740827c63dac874bf18f121 by Aleix Pol Gonzalez, on
behalf of Aleix Pol.
Committed on 19/07/2024 at 00:54.
Pushed by apol into branch 'master'.

ApplicationPage: Do not use Item.visible to calculate the visibility of the
parent

Having the parent visible=false will make all children visible:false so
it becomes a silly exercise.

Instead, use a property made for this that doesn't have other
connotations.

It kind of feels like we are workarounding a bug in the layout class but
this is needs addressing now.

M  +48   -1    discover/DiscoverDeclarativePlugin.cpp
M  +17   -10   discover/qml/ApplicationPage.qml
M  +1    -0    libdiscover/backends/DummyBackend/CMakeLists.txt
M  +6    -0    libdiscover/backends/DummyBackend/DummyResource.cpp
M  +1    -0    libdiscover/backends/DummyBackend/DummyResource.h
C  +3    -4    libdiscover/backends/DummyBackend/qml/DummyTop.qml [from:
libdiscover/backends/FlatpakBackend/qml/FlatpakAttention.qml - 063% similarity]
A  +6    -0    libdiscover/backends/DummyBackend/resources.qrc
M  +1    -1    libdiscover/backends/FlatpakBackend/qml/FlatpakAttention.qml
M  +1    -1    libdiscover/backends/FlatpakBackend/qml/FlatpakEolReason.qml
M  +1    -1    libdiscover/backends/FlatpakBackend/qml/FlatpakOldBeta.qml
M  +1    -1    libdiscover/backends/FlatpakBackend/qml/FlatpakRemoveData.qml
M  +1    -2    libdiscover/backends/FlatpakBackend/qml/PermissionsList.qml
M  +1    -2   
libdiscover/backends/PackageKitBackend/qml/DependenciesButton.qml
M  +1    -0   
libdiscover/backends/PackageKitBackend/qml/PackageKitPermissions.qml
M  +1    -1    libdiscover/backends/SnapBackend/qml/ChannelsButton.qml
M  +1    -1    libdiscover/backends/SnapBackend/qml/PermissionsButton.qml

https://invent.kde.org/plasma/discover/-/commit/101c01494ede10659740827c63dac874bf18f121

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to