https://bugs.kde.org/show_bug.cgi?id=458711
Ilya Bizyaev <bizy...@zoho.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/plas
| |ma/ksshaskpass/-/commit/882
| |b13214d9d6409210ea18a1163b5
| |d104c8dc26
Status|ASSIGNED |RESOLVED
--- Comment #3 from Ilya Bizyaev <bizy...@zoho.com> ---
Git commit 882b13214d9d6409210ea18a1163b5d104c8dc26 by Ilya Bizyaev.
Committed on 28/06/2024 at 11:47.
Pushed by ilyabizyaev into branch 'master'.
Add support for SSH_ASKPASS_PROMPT
Since 2019, OpenSSH sets the `SSH_ASKPASS_PROMPT` environment variable
to inform askpass programs what UI they should display:
*
https://github.com/openssh/openssh-portable/commit/b497e920b409250309c4abe64229237b8f2730ba
*
https://lists.mindrot.org/pipermail/openssh-unix-dev/2019-November/038032.html
There are 3 reported types:
* "confirm": `[Yes] No`
* "none" (e.g. for proof of presence): `[Close]`
* "" (referred to as "entry"): `|Text field| [OK] Cancel`
These are a subset of UI display modes already supported by KSSHAskPass,
so this commit only changes the detection logic. I attempted to make this
change
minimally invasive and self-contained.
Reading the environment variable is more reliable than parsing strings.
In particular, certain SSH agents used in corporate environments use
different prompt formats, which was not compatible with KSSHAskPass.
The pre-existing display type enum is kept separate for now because it
also supports cleartext. Some string parsing also remains in place for
KWallet password storage. I can attempt to refactor model logic in a
follow-up MR.
M +58 -94 src/main.cpp
https://invent.kde.org/plasma/ksshaskpass/-/commit/882b13214d9d6409210ea18a1163b5d104c8dc26
--
You are receiving this mail because:
You are watching all bug changes.
