https://bugs.kde.org/show_bug.cgi?id=391146
Tuomas Nurmi <tuo...@norsumanageri.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/mult
| |imedia/amarok/-/commit/312c
| |36046bf49dadb2edbb0398989ff
| |b6230c3e0
Status|ASSIGNED |RESOLVED
--- Comment #5 from Tuomas Nurmi <tuo...@norsumanageri.org> ---
Git commit 312c36046bf49dadb2edbb0398989ffb6230c3e0 by Tuomas Nurmi.
Committed on 21/06/2024 at 10:31.
Pushed by nurmi into branch 'master'.
Some theoretical mp3tunes fixes
Fix the regexes so it compiles again. Add fixes to reported bugs, including a
patch
posted by Zhouyang on bugs.kde.org. Fix some issues reported by code quality
scans.
The compilation works now, but no effort was made even to try to test the
functionality,
which probably doesn't. The service as is would need work and everything is
turned off
in CMakeLists. Hard to predict if someone will ever update the mp3tunes to
usable state,
but I guess there's no point in NOT applying the potential fixes (as the
service still
exists, so maybe not everything's not broken enough to justify removing) so the
existing
issues can be happily cleaned up at least.
Related: bug 419132
M +3 -2 src/services/mp3tunes/Mp3tunesService.cpp
M +3 -3 src/services/mp3tunes/Mp3tunesServiceCollection.cpp
M +27 -5 src/services/mp3tunes/libmp3tunes/locker.c
https://invent.kde.org/multimedia/amarok/-/commit/312c36046bf49dadb2edbb0398989ffb6230c3e0
--
You are receiving this mail because:
You are watching all bug changes.
