https://bugs.kde.org/show_bug.cgi?id=336866
Martin Gräßlin <mgraess...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |http://commits.kde.org/kwin
| |/fb69b791a16f4a89fd79a010ce
| |8f67419de16004
Version Fixed In| |5.8.4
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #10 from Martin Gräßlin <mgraess...@kde.org> ---
Git commit fb69b791a16f4a89fd79a010ce8f67419de16004 by Martin Gräßlin.
Committed on 07/11/2016 at 10:45.
Pushed by graesslin into branch 'Plasma/5.8'.
Ensure that all Effects honour the grab roles correctly
Summary:
When windows get added some effects grab the window and want to be the
only one animating this window. For this the grab roles exists. An
effect being notified later on evaluates the grab state and does not
start the animation.
This process failed due to being dependent on the order the effects are
loaded. Window Added/Closed are signals emitted by EffectsHandler, thus
first come, first serve. The requested effect order does not play into
it.
Due to that it could happen that an Effect which should not animate,
started to animate as the grab was still there.
This change adds the possibility to be notified whenever the window data
changes. A new signal is added to EffectsHandler which is emitted
whenever the windowData changes. The interested effects connect to it
and cancel their (just started) animation for the window.
Adjusted effects are:
* ScaleIn
* Fade
* WobblyWindows
In case of WobblyWindows an additional logical error was fixed that the
animations were only run when an effect grabbed instead of the other way
around.
FIXED-IN: 5.8.4
Reviewers: #kwin, #plasma, broulik
Subscribers: plasma-devel, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D3211
M +0 -12 autotests/integration/effects/slidingpopups_test.cpp
M +1 -0 effects.cpp
M +19 -2 effects/fade/package/contents/code/main.js
M +13 -1 effects/scalein/package/contents/code/main.js
M +0 -1 effects/slidingpopups/slidingpopups.cpp
M +29 -2 effects/wobblywindows/wobblywindows.cpp
M +1 -0 effects/wobblywindows/wobblywindows.h
M +18 -0 libkwineffects/kwineffects.h
http://commits.kde.org/kwin/fb69b791a16f4a89fd79a010ce8f67419de16004
--
You are receiving this mail because:
You are watching all bug changes.
