https://bugs.kde.org/show_bug.cgi?id=487348

Nicolas Fella <nicolas.fe...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
                   |eworks/kwallet/-/commit/425 |eworks/kwallet/-/commit/fc0
                   |cf15fc9116a1fc115dd52eb5537 |97984e7a6ea127fe7e0ca9df2ff
                   |c2eb5d66be                  |98271888d3

--- Comment #7 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit fc097984e7a6ea127fe7e0ca9df2ff98271888d3 by Nicolas Fella.
Committed on 24/05/2024 at 19:55.
Pushed by nicolasfella into branch 'Frameworks/6.2'.

Fix secrets portal wallet access

The current code checks whether the wallet is open and only if it's not calls
openAsync

However kwallet internally tracks which apps have openend the wallet and only
gives access to those that have called open

This works fine if the portal request triggered the opening of the wallet and
subsequent access works, but if the wallet was opened by another app before any
attempt to read from the wallet will fail

To fix this always open the wallet before accessing. This allows to simplify
the code since we then can tie a portal request to a KWallet transaction ID.

Also consistently use xdg-desktop-portal as appid when making calls to kwallet
(cherry picked from commit 425cf15fc9116a1fc115dd52eb5537c2eb5d66be)

M  +11   -25   src/runtime/kwalletd/kwalletportalsecrets.cpp
M  +1    -3    src/runtime/kwalletd/kwalletportalsecrets.h

https://invent.kde.org/frameworks/kwallet/-/commit/fc097984e7a6ea127fe7e0ca9df2ff98271888d3

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to