[valgrind] [Bug 487296] --track-fds=yes and --track-fds=all report erroneous information when fds 0, 1, or 2 are used as non-std

[Mark Wielaard]

https://bugs.kde.org/show_bug.cgi?id=487296

--- Comment #3 from Mark Wielaard <m...@klomp.org> ---
For each inherited fd VG_(init_preopened_fds) calls
ML_(record_fd_open_named)(-1, fd);
So the ThreadId will be -1. Which ML_(record_fd_open_with_given_name) documents
as
"If the tid is -1, this indicates an inherited fd."
Which in practice means the struct OpenFd where field will be set to NULL
   ExeContext *where;             /* NULL if inherited from parent */

So what we could probably do, instead of having a special static Bool
std_fds[3], is checking for where == NULL instead. Which would handle all
inherited file descriptors, not just 0, 1, 2.

Does that make sense? Would that be useful?

-- 
You are receiving this mail because:
You are watching all bug changes.