https://bugs.kde.org/show_bug.cgi?id=362657
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |http://commits.kde.org/plas
| |ma-workspace/926a7f71df80bd
| |cc0f2816a03658342a3f4e8f32
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #7 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 926a7f71df80bdcc0f2816a03658342a3f4e8f32 by David Edmundson.
Committed on 04/11/2016 at 11:31.
Pushed by davidedmundson into branch 'master'.
Close the system tray on escape - system tray
Summary:
A lot of applets have independent handling making escape close the
expanded representation. However not all of them do.
This leads to both duplicated code and inconsistencies, so we should
tackle this at the source.
If an applet was already using escape internally it will be accepting
the event, and so this code will not cause any regressions.
This patch also removes the stackview forwarding events to the active
child as this doesn't make sense - the active child will already have
focus and get the key event first, so this just created a recursive
chain (which Qt was thankfully fixing for us). Removing it is needed for
this to work.
Test Plan:
Pressed escape on various applets (e.g plasma-pa)
Pressed escape on the expander applet list view
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3257
M +0 -1
applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
M +6 -0 applets/systemtray/package/contents/ui/main.qml
http://commits.kde.org/plasma-workspace/926a7f71df80bdcc0f2816a03658342a3f4e8f32
--
You are receiving this mail because:
You are watching all bug changes.
