https://bugs.kde.org/show_bug.cgi?id=429654

--- Comment #4 from Alexander Semke <alexander.se...@web.de> ---
(In reply to Mark Capella from comment #3)
> I was hoping to patch this but it looks already corrected here:
> https://invent.kde.org/games/knights/-/commit/
> bc828eb7e7ec50392b0bfe9118bb367d84d540a7
> 
> If confirmed can we close?
That commit only disable the sounds played when moving the pieces. This bug
report about not being able to disable the spoken voice for the actual moves
("pawn to d4", etc.). To reproduce this problem you need to have knights
compiled with Qt6SpeechToText engine installed. We need to add an additional
option that will allow to disable the voice similar to how it's already
possible to disable the move sounds. This option should only be shown if the
application was compiled with Qt6SpeechToText.

The relevant logic is in gamemanager.cpp (search for #ifdef HAVE_SPEECH) and I
see already it's being checked via  Settings::speakOpponentsMoves() but the
setting itself is not available in the settings dialog (anymore?). Do you want
to prepare a patch for this?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to