https://bugs.kde.org/show_bug.cgi?id=172921
ratijas <m...@ratijas.tk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/plas
| |ma/kwin/-/commit/344e56dd77
| |e90476023e434e48382b566def1
| |3a2
Resolution|--- |FIXED
--- Comment #26 from ratijas <m...@ratijas.tk> ---
Git commit 344e56dd77e90476023e434e48382b566def13a2 by ivan tkachenko.
Committed on 12/04/2024 at 16:39.
Pushed by ratijas into branch 'master'.
plugins/dialogparent: Disable darkening while picking colors
Integrate with colorpicker effect to disable window darkening while
color picker effect is active. Unfortunately, this solution has couple
of limitations:
- active state of effects is not an observable property, so a new
property had to be added to the effects singleton;
- consequently, list of active effects is not an observable property, so
the whole thing could not be implemented in pure QML in the dialog
parent effects;
- actual isActive() state of the color picker for whatever reason
required that m_scheduledPosition is not an invalid point,
effectively making it always inactive except for a brief moment
between addRepaintFull() call and paintScreen() callback. That check
had to be removed.
- QColorDialog windows are still modal and darkened by default;
- QColorDialog on X11 does not use portals/KWin, so this trick does not
apply at all;
- effects->isScreenLocked() which isActive() depends on is not an
observable property either.
M +5 -0 src/effect/effecthandler.cpp
M +9 -1 src/effect/effecthandler.h
M +16 -5 src/plugins/colorpicker/colorpicker.cpp
M +1 -0 src/plugins/colorpicker/colorpicker.h
M +23 -23 src/plugins/dialogparent/package/contents/code/main.js
https://invent.kde.org/plasma/kwin/-/commit/344e56dd77e90476023e434e48382b566def13a2
--
You are receiving this mail because:
You are watching all bug changes.
