https://bugs.kde.org/show_bug.cgi?id=444431

Paul Floyd <pjfl...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |NOT A BUG
                 CC|                            |pjfl...@wanadoo.fr

--- Comment #8 from Paul Floyd <pjfl...@wanadoo.fr> ---
You code is truly horrible. gotos everywhere. Including C source in the middle
of a file. K&R non-prototype function declarations. The Makefile looks like it
is trying to be a script. The Makefile mixes compiler flags and linker flags
willy nilly. You really need to learn how to program correctly.

The first error is on this line

│  >   144          val = (arg[1][argl[1] - 1] == '$') ? defaultstr :
defaultnu│

arg is

    char **arg = NULL;

and argl is

    int32_t *argl = NULL;

The seem to be allocated OK.

arg[1] contains "TEST".
argl[1] contains 6.

Than means you are accessing the 6-1 = 5 or the 6th byte in arg[1]. But it only
points to 5 bytes. 

There are lots of bugs in the code. For a start I think that

        argl[i] = ngptr - gptr;

is out by one and should be

        argl[i] = ngptr - gptr - 1;

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to