https://bugs.kde.org/show_bug.cgi?id=371562
--- Comment #2 from Aleix Pol <aleix...@kde.org> --- Git commit 91dbd2f5a30caf878f668e60b7c2ee5ca376b858 by Aleix Pol. Committed on 30/10/2016 at 23:27. Pushed by apol into branch 'master'. Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILES Summary: Instead of having an odd fake of it. Will help some required refactorings and already showed some issues, fixed by this patch, namely: - don't use string(regex replace) to extract a string from another string. in case it doesn't match it will offer the whole content which is never what we want. - messages(ERROR), the correct parameter is FATAL_ERROR, cmake understands "ERROR" as mere output string - turn the macro into a function, otherwise 2 calls in the same subdirectory are dangerous. Test Plan: tests still pass, projects that use the macro still build Reviewers: #frameworks, dfaure Reviewed By: dfaure Subscribers: dfaure Differential Revision: https://phabricator.kde.org/D3178 M +18 -9 KF5ConfigMacros.cmake M +12 -29 autotests/kconfig_compiler/CMakeLists.txt M +1 -0 autotests/kconfig_compiler/test1.kcfgc M +1 -0 autotests/kconfig_compiler/test12.kcfgc M +1 -0 autotests/kconfig_compiler/test13.kcfgc M +1 -0 autotests/kconfig_compiler/test9.kcfgc M +1 -1 autotests/kconfig_compiler/test_qdebugcategory.kcfgc http://commits.kde.org/kconfig/91dbd2f5a30caf878f668e60b7c2ee5ca376b858 -- You are receiving this mail because: You are watching all bug changes.
