https://bugs.kde.org/show_bug.cgi?id=484652
Noah Davis <noaha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
|hics/spectacle/-/commit/73b |hics/spectacle/-/commit/5b8
|88ab1eaee494c578ffe1fd2cafa |d6193561830036e7ad916ebbfd0
|8dd0d437a1 |4a268af7ad
--- Comment #6 from Noah Davis <noaha...@gmail.com> ---
Git commit 5b8d6193561830036e7ad916ebbfd04a268af7ad by Noah Davis, on behalf of
Konstantin Kharlamov.
Committed on 05/04/2024 at 15:56.
Pushed by ndavis into branch 'release/24.02'.
SpectacleCore: make class inheritance check more robust
Commit
f410b0814 "Rename Platform* to ImagePlatform*"
introduced a regression by making spectacle window visible at the
moment of making rectangular screenshot. That happened because the
check for inheritance was using a string instead of a dynamic/qobject
cast, so after the rename the fact the code broke went unnoticed.
Fix that by using qobject_cast() instead, so if rename ever happens
again the code would refuse to compile.
While at it, also add a point that the delay there isn't only because
of the crash but also because X11 compositors different from kwin may
require some time for effects to disappear before the shot can be
made.
(cherry picked from commit 73b88ab1eaee494c578ffe1fd2cafa8dd0d437a1)
M +7 -4 src/SpectacleCore.cpp
https://invent.kde.org/graphics/spectacle/-/commit/5b8d6193561830036e7ad916ebbfd04a268af7ad
--
You are receiving this mail because:
You are watching all bug changes.
