https://bugs.kde.org/show_bug.cgi?id=484598

Jack Hill <jackhill3...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/ktorrent/-/commit/5d216
                   |                            |c0b8c9b71c74ae5af755b0a0082
                   |                            |f54af83f
         Resolution|---                         |FIXED

--- Comment #1 from Jack Hill <jackhill3...@gmail.com> ---
Git commit 5d216c0b8c9b71c74ae5af755b0a0082f54af83f by Jack Hill.
Committed on 02/04/2024 at 16:01.
Pushed by jackh into branch 'master'.

Undo system tray bug workaround

In KF5 KStatusNotifierIcon would show/hide the main QWindow whilst in KTorrent
we would show/hide the main QWidget. A bug in Qt6 meant that hiding/showing
the QWindow did not neccessarily hide the QWidget.

So if a user closed the window to the tray, the QWidget was considered hidden
but the QWindow was not. Then when clicking on the tray icon, the QWindow
visiblity was being toggled but the QWidget visibility was always hidden.

To work around this we changed KTorrent to hide the QWindow instead of the
QWidget. Now KStatusNotifierIcon has been updated to hide the main QWidget
instead of the QWindow, so we must undo the changes made here.

The upstream bug should fixed in Qt 6.7 anyway.

Reverts e35b4881605f045ebe8bca2da357c2a3ae2f1e02

Reverts efe4aa0dcc23e57e68ecd809068f1a49d7705a07

M  +5    -10   ktorrent/gui.cpp
M  +1    -2    ktorrent/main.cpp

https://invent.kde.org/network/ktorrent/-/commit/5d216c0b8c9b71c74ae5af755b0a0082f54af83f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to