https://bugs.kde.org/show_bug.cgi?id=481069

--- Comment #26 from Flossy Cat <flossy-...@online.de> ---
Thank you!

When you are at it, kindly consider the following improvement (sample code
below) (see also https://bugs.kde.org/show_bug.cgi?id=481068):

IMPROVEMENT

Add pre-filled environment variables with notification details.

RATIONALE

For anything not directly solvable with an existing program the users typically
will have to script.
Providing all notification details in environment variables significantly
simplifies this:
* Tighter test-loop: no need to adapt the call in the KDE UI, when other
details should be used
* no need for parameter parsing

CODE (suggestion)

In »notifybyexecute.cpp« insert between
     KProcess proc;
and
     proc.setShellCommand(execLine.trimmed());
the following 

// code suggestion start
const std::string envPrefix = "KDE_NOTIFICATION_PARAMS_"; // name-space, your
choice
proc.setEnv(envPrefix + "EventID", notification->eventId() ) // or any string
concatenation of your choice
proc.setEnv(envPrefix + "AppName", notification->appName() )
proc.setEnv(envPrefix + "DisplayName",
QGuiApplication::applicationDisplayName() )
proc.setEnv(envPrefix + "Title", notification->title() )
proc.setEnv(envPrefix + "Text", notification->text() )
// code suggestion end

Thank in advance!

I will support with end user documentation in English and German if pointed to
the proper entry point.
(I consider end user documentation essential for this feature to communicate
the potential.)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to