[krunner] [Bug 483412] When search field has focus, End key goes to the last entry in the results view, not the end of the search field

[András Manţia]

https://bugs.kde.org/show_bug.cgi?id=483412

--- Comment #5 from András Manţia <aman...@kde.org> ---
Here is a proposed patch (couldn't test as right now I have some config issues
to build plasma-workspace):
diff --git a/krunner/qml/RunCommand.qml b/krunner/qml/RunCommand.qml
index d7f174d938..48843057f4 100644
--- a/krunner/qml/RunCommand.qml
+++ b/krunner/qml/RunCommand.qml
@@ -228,16 +228,17 @@ ColumnLayout {
                         event.accepted = true;
                     }
                 }
+
+                var inCompletionMode = runnerWindow.historyBehavior ===
HistoryBehavior.CompletionSuggestion
+                    && fadedTextCompletion.text.length > 0;
                 // We only need to handle the Key_End case, the first item is
focused by default
-                if (event.key === Qt.Key_End && results.count > 0 &&
cursorPosition === text.length) {
+                if (event.key === Qt.Key_End && results.count > 0 &&
cursorPosition === text.length && !inCompletionMode) {
                     results.currentIndex = results.count - 1
                     event.accepted = true;
                     focusCurrentListView()
                 }
-                if (runnerWindow.historyBehavior ===
HistoryBehavior.CompletionSuggestion
-                    && fadedTextCompletion.text.length > 0
-                    && cursorPosition === text.length
-                    && event.key === Qt.Key_Right
+                if (inCompletionMode && cursorPosition === text.length
+                    && (event.key === Qt.Key_Right || event.key == Qt.Key_End)
                 ) {
                     queryField.text = fadedTextCompletion.text
                     fadedTextCompletion.text = ""

-- 
You are receiving this mail because:
You are watching all bug changes.