https://bugs.kde.org/show_bug.cgi?id=361785
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |k...@davidedmundson.co.uk
--- Comment #3 from David Edmundson <k...@davidedmundson.co.uk> ---
Thanks for the patch, just so you know, we tend to use
http://git.reviewboard.kde.org for patches, ones on bugs tend to get missed,
particularly in less active components.
The patch itself could do with some work;
right now you're effectively resorting the entire list on every insert, and
with a regular expression too.
You should be able to identify where in the list to insert, then insert at that
position using:
auto place = std::lower_bound(list.constStart, list.constEnd, newItem,
compareFunction);
list.insert(place, newItem);
also instead of a regular expression you should be able to use QCollator with
http://doc.qt.io/qt-5/qcollator.html#setNumericMode
--
You are receiving this mail because:
You are watching all bug changes.
