https://bugs.kde.org/show_bug.cgi?id=481665

Noah Davis <noaha...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/spectacle/-/commit/c03
                   |                            |141f6cf5919cc670f1833589c1d
                   |                            |54d7405d44
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Noah Davis <noaha...@gmail.com> ---
Git commit c03141f6cf5919cc670f1833589c1d54d7405d44 by Noah Davis.
Committed on 04/03/2024 at 14:51.
Pushed by ndavis into branch 'master'.

AnnotationViewport: Don't use TextureCanUseAtlas

It was the wrong thing to use with these textures and was likely causing the
GPU to run out of memory. That caused the textures to sometimes render all
black despite being perfectly fine internally.

TextureCanUseAtlas is best used with lots of small static images. Atlas texture
sizes are padded to powers of two, so adding a large image to the atlas makes
the atlas use up far more space than necessary. We also use mipmaps with the
screenshot textures, so that uses up even more GPU memory with the already
massive atlas texture.

I also removed the explicit TextureHasAlphaChannel option because it was
redundant.

M  +2    -4    src/Gui/Annotations/AnnotationViewport.cpp

https://invent.kde.org/graphics/spectacle/-/commit/c03141f6cf5919cc670f1833589c1d54d7405d44

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to