https://bugs.kde.org/show_bug.cgi?id=478835

Nicolas Fella <nicolas.fe...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kio/-/commit/8835710
                   |                            |a73c2ba348ad615fd2a8883cfa6
                   |                            |d999e1

--- Comment #3 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit 8835710a73c2ba348ad615fd2a8883cfa6d999e1 by Nicolas Fella.
Committed on 25/01/2024 at 14:36.
Pushed by nicolasfella into branch 'master'.

[kprocessrunner] Clean up maybeAliasedName

maybeAliasedName does two things:

- resolving the potential alias for m_service
- Fill in a given pattern with the result and a UUID

Mixing those two things in a single function is dangerous.

For requestXdgActvationToken we want to resolve the alias, but not
do any of the pattern/UUID stuff that is only for the system runners.

Shuffle things around to make it more clear.

Also make sure that m_service is set before resolveServiceAlias is called

M  +26   -27   src/gui/kprocessrunner.cpp
M  +1    -1    src/gui/kprocessrunner_p.h
M  +2    -1    src/gui/systemd/scopedprocessrunner.cpp
M  +2    -1    src/gui/systemd/systemdprocessrunner.cpp

https://invent.kde.org/frameworks/kio/-/commit/8835710a73c2ba348ad615fd2a8883cfa6d999e1

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to