https://bugs.kde.org/show_bug.cgi?id=477423

--- Comment #3 from Jakob Petsovits <j.acco...@petsovits.com> ---
Created attachment 163687
  --> https://bugs.kde.org/attachment.cgi?id=163687&action=edit
system-log-out.svg: draft of a 16px icon version

Alternatively, we could ask the graphics team for a 16px icon with circle. I
tried my hand at one (see attachment), same circle dimension as the do-nothing
icon, but the number of pixels is getting pretty low there so it's hard to get
a pointy arrowhead without taking the arrow off-center. I'm also not an expert
at pixel-perfect anti-aliasing alignments.

In terms of changing KQuickStyleItem, the default icon size is set by
qqc2-desktop-style/plugin/kquickstyleitem.cpp and tied to
KQuickStyleItem::style()->pixelMetric(QStyle::PM_ButtonIconSize, m_styleoption,
nullptr), which is used in a bunch of other components as well. Not sure if
changing the default is good for consistency overall. In the powerdevil UI, one
can try the 22px version by adding:

            props.iconWidth = props.iconHeight = 22;

to background.properties in
powerdevil/kcmodule/profiles/ui/ComboBoxWithIcon.qml - it looks okay, I guess.
A little more in-your-face in terms of icon prominence. However, that hardcoded
value doesn't work for the general case because it will break on higher-DPI
setups.

In the popup list, the icon width could be reduced by setting icon.width and
icon.height to 16 for the the QQC2.ItemDelegate in the same file. This actually
reduces the overall height of the list item, making it look a little weird and
harder to select. Not great overall, and also not clear where to get the real
value from in general, because we don't really have insight into the
KQuickStyleItem there anyway.

Overall, I'm leaning towards updating the 16px icon (however imperfect it might
end up compared to the larger versions) and as an alternative, exploring a
larger (22px) icon size for ComboBox and potentially related UI components.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to