https://bugs.kde.org/show_bug.cgi?id=477433
Bug ID: 477433
Summary: Incorrect prompt "Can't compare file with folder" from
command-line when only specify two folder
Classification: Applications
Product: kdiff3
Version: unspecified
Platform: Arch Linux
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: application
Assignee: reeves...@gmail.com
Reporter: mr.ymin...@gmail.com
Target Milestone: ---
SUMMARY
Error prompted "Can't compare file with folder" when using kdiff3 to compare
two folders from command-line. I read the source code, maybe need to check
m_sd3 is empty when doing directory compare cause the third folder is optional.
```
- if((m_bDirCompare && (!m_sd2->isDir() || !m_sd3->isDir())) ||
+ if((m_bDirCompare && (!m_sd2->isDir() || (!m_sd3->isEmpty() &&
!m_sd3->isDir()))) ||
(!m_bDirCompare && (m_sd2->isDir() || m_sd3->isDir())))
{
...
}
```
STEPS TO REPRODUCE
1. install kdiff3-git from AUR
2. execute "kdiff3 folder1 folder2"
3.
OBSERVED RESULT
KMessageBox popped with "Can't compare file with folder"
EXPECTED RESULT
No "Can't compare file with folder" prompted
SOFTWARE/OS VERSIONS
Windows:
macOS:
Linux/KDE Plasma:
(available in About System)
KDE Plasma Version:
KDE Frameworks Version:
Qt Version:
ADDITIONAL INFORMATION
--
You are receiving this mail because:
You are watching all bug changes.
