https://bugs.kde.org/show_bug.cgi?id=445940

Christoph Cullmann <cullm...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/ktexteditor/-/commit
                   |                            |/e545a6254f3a3e3084e8a9a373
                   |                            |81983c463a8136
         Resolution|---                         |FIXED

--- Comment #8 from Christoph Cullmann <cullm...@kde.org> ---
Git commit e545a6254f3a3e3084e8a9a37381983c463a8136 by Christoph Cullmann, on
behalf of Waqar Ahmed.
Committed on 20/11/2023 at 18:25.
Pushed by waqar into branch 'master'.

Make completion a normal widget that is floating

Right now completion is a window which results in various issues with
wayland vs X. Making it a widget simplifies our code a lot as we
don't need to think about the window manager at all or do manual
position tracking.

The widget is parented to the "window", for kate this means
KateMainWindow and for other apps it will be the top level window in
which the view lives. The reason it is parented to the window is
because we still want to be able to use the entire space available to
the mainWindow. This can be important if you are using splits as the
view width will be much smaller.

This also fixes the blinking crap/dirty regions that results from
completion widget.

M  +8    -29   src/completion/documentation_tip.cpp
M  +1    -1    src/completion/documentation_tip.h
M  +0    -1    src/completion/kateargumenthinttree.cpp
M  +2    -2    src/completion/katecompletiontree.cpp
M  +42   -58   src/completion/katecompletionwidget.cpp
M  +1    -3    src/completion/katecompletionwidget.h
M  +2    -0    src/view/kateview.cpp

https://invent.kde.org/frameworks/ktexteditor/-/commit/e545a6254f3a3e3084e8a9a37381983c463a8136

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to