https://bugs.kde.org/show_bug.cgi?id=476903

Neal Gompa <ngomp...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ngomp...@gmail.com

--- Comment #4 from Neal Gompa <ngomp...@gmail.com> ---
(In reply to Nate Graham from comment #3)
> Aha!
> 
> But it's weird that we have `appstreamcli validate` and also `appstream-util
> validate` and they don't agree on whether the file is valid or not. I'm also
> confused by the assertion that the "preferences-security-firewall" icon
> isn't valid. It's a perfectly acceptable FDO-compatible icon name, and an
> icon by that name exists in Breeze, which is the icon theme that users are
> expected to be using or inheriting from when they see this software in
> Plasma. It's not really intended to work in GNOME or anywhere else.
> 
> I did some digging and found
> https://github.com/hughsie/appstream-glib/issues/360. Apparently with
> `appstream-util validate` there's a whitelist of allowed icon names, and the
> purpose of this check is to encourage apps to ship with their own custom
> icons, rather than relying on icon themes. Richard Hughes says he's willing
> to whitelist anything in Hicolor and Adwaita, but makes no mention of Breeze
> or any other icon theme.
> 
> I think it's somewhat uncool to see the preferences of GNOME project members
> creep into cross-desktop tools, as well as the idea of whitelisting GNOME
> stuff but not KDE stuff. As such, I think I can say that in KDE we don't
> consider this error to be an error. Notably, we validate our appstream files
> with `appstreamcli validate` which does not count it as an error.
> 
> Maybe the real solution here is to remove the appstream metainfo file in the
> first place, as this software isn't really an app that a random user on a
> random distro and a random desktop environment can install and expect to
> work.
> 
> Can you maybe bring that up at
> https://invent.kde.org/plasma/plasma-firewall/-/issues/ and reference the
> discussion here?

First, I'm going to see if I can get as-util to include our stock icon names,
and if that fails, then I'll go talk to them.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to