https://bugs.kde.org/show_bug.cgi?id=370495

Kevin Funk <kf...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.0.2
      Latest Commit|                            |http://commits.kde.org/kdev
                   |                            |platform/3c395340d9ee7c936f
                   |                            |7c2a5895b28078ae4a5ce5
             Status|CONFIRMED                   |RESOLVED

--- Comment #2 from Kevin Funk <kf...@kde.org> ---
Git commit 3c395340d9ee7c936f7c2a5895b28078ae4a5ce5 by Kevin Funk.
Committed on 11/10/2016 at 23:40.
Pushed by kfunk into branch '5.0'.

BackgroundParserPrivate::createParseJob: Fix race

While creating a parse job we temporarily unlock the mutex used to
ensure access to the BackgroundParsers shared data is exclusive.

But this is problematic:
 a) we use data which can be modified by other threads
 b) we use iterators which could have become invalid
    since the underlying container got modified by other threads

This almost instantly crashes the KDevelop on Windows version when there
multiple language plugins creating parse jobs in parallel.
FIXED-IN: 5.0.2

M  +16   -6    language/backgroundparser/backgroundparser.cpp

http://commits.kde.org/kdevplatform/3c395340d9ee7c936f7c2a5895b28078ae4a5ce5

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to