https://bugs.kde.org/show_bug.cgi?id=473214

ratijas <m...@ratijas.tk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kirigami/-/commit/1a
                   |                            |969a18d91a006420594cf86d8c6
                   |                            |5bb51a1ec3f
         Resolution|---                         |FIXED

--- Comment #11 from ratijas <m...@ratijas.tk> ---
Git commit 1a969a18d91a006420594cf86d8c65bb51a1ec3f by ivan tkachenko, on
behalf of Jack Hill.
Committed on 11/10/2023 at 18:07.
Pushed by ratijas into branch 'appwindow-global-drawer-bindings'.

AbstractApplicationWindow: Clean up bindings, fix reparenting of drawers

Querying QQC2.Overlay.overlay attached property on a Binding object was
clearly wrong. It just resulted in null at all times, so basically
those Bindings never took effect.

Since `when:` condition does not make much sense (first, those
properties could never be undefined; second, why reparenting only when
visible?), let's demote them into a property change handlers with null
guards.

For other bindings, pointless `when` check was removed as well as
deprecated (and yet again pointless) restoreMode.
Co-Authored-By: Jack Hill <jackhill3...@gmail.com>

M  +20   -22   src/controls/AbstractApplicationWindow.qml

https://invent.kde.org/frameworks/kirigami/-/commit/1a969a18d91a006420594cf86d8c65bb51a1ec3f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to