https://bugs.kde.org/show_bug.cgi?id=445893
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/fram
| |eworks/plasma-framework/-/c
| |ommit/258cecbf0fab27ee84ad6
| |c43ff3cfe3647215afd
--- Comment #29 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 258cecbf0fab27ee84ad6c43ff3cfe3647215afd by David Edmundson.
Committed on 01/09/2023 at 15:32.
Pushed by davidedmundson into branch 'master'.
windowthumbnail: Cleanup on scene graph invalidation
The documentation
(https://doc.qt.io/qt-6/qquickitem.html#graphics-resource-handling)
states that if we are doing our own low level handling of graphic
resources we need to perform cleanup in 3 places:
- on item destruction
- when an item is removed from the scene (via the virtual
releaseResources)
- when the scenegraph gets invalidated (via a slot
invalidateSceneGraph)
We only handled the first two.
This would cause a crash if the window thumbnail is showing just an icon
instead of a thumbnail and we hit one of the nvidia context loss resets.
The atlas texture would be deleted, but we would keep a QSGTexture
refernecing something inside that for longer which would linger.
I believe we only need the texture provider to reset, but we may as well
do it all.
BUG:
M +27 -0 src/declarativeimports/core/windowthumbnail.cpp
M +3 -0 src/declarativeimports/core/windowthumbnail.h
https://invent.kde.org/frameworks/plasma-framework/-/commit/258cecbf0fab27ee84ad6c43ff3cfe3647215afd
--
You are receiving this mail because:
You are watching all bug changes.
