https://bugs.kde.org/show_bug.cgi?id=471807

Aaron Merey <ame...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #160636|0                           |1
        is obsolete|                            |

--- Comment #10 from Aaron Merey <ame...@redhat.com> ---
Created attachment 160848
  --> https://bugs.kde.org/attachment.cgi?id=160848&action=edit
patch v5

(In reply to Mark Wielaard from comment #9)
> (In reply to Aaron Merey from comment #8)
> > Maybe there are some cases where it is preferable for valgrind to
> > minimize pausing execution of the client process? Downloading
> > debuginfo as soon as the shared library is linked might be better
> > here.
> 
> In that case it might be simpler to simply disable all debuginfo downloading.
> If you think it really is an option people would use then ok.
> But I do like to keep the number of (unused) options and code paths to a
> minimum when possible.

Fair enough, we can always add the option later if there is a desire for it.
Patch v5 attachment has the option removed.

> Can we do something like:
> 
>    if (iipc && iipc->di)
>       VG_(load_di) (iipc->di, eip);
>    else
>       VG_(addr_load_di) (eip);
> 
> To reduce the extra search? And is the else part really necessary?

Patch v5 has this added to describe_IP. The else part is necessary since
removing it caused testsuite regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to