https://bugs.kde.org/show_bug.cgi?id=465422
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |6.0
Resolution|WORKSFORME |FIXED
Latest Commit| |https://invent.kde.org/fram
| |eworks/kirigami/-/commit/bd
| |b322527fbc910ce7124a45dc43d
| |faa0fad1522
--- Comment #6 from Nate Graham <n...@kde.org> ---
Git commit bdb322527fbc910ce7124a45dc43dfaa0fad1522 by Nate Graham.
Committed on 04/08/2023 at 16:58.
Pushed by ngraham into branch 'master'.
Icon: Remove automatic heuristic-based monochrome icon re-coloring
This feature has caused many bugs over the years and its value is
dubious to begin with. Automatically masking a colorful icon to instead
be monochrome based on this or that heuristic violates the integrity of
the user's icon theme and enforces a stylistic preference for monochrome
icons that is not appropriate to do at the library level.
If the user is using an icon theme whose icons have any color in them
despite being 16 or 22px size or using the `-symbolic` suffix, this
needs to be considered an intentional stylistic choice on the part of
the icon theme, and it isn't something that we should monkey with here.
As a bonus, we also reap an efficiency win by simply doing less
unnecessary work most of the time.
If a developer wants to do this masking anyway, they are still free to
set `mask: true` in their code and then it will happen on an opt-in
basis.
Related: bug 473001, bug 471803, bug 469978, bug 451538
FIXED-IN: 6.0
M +2 -93 src/icon.cpp
https://invent.kde.org/frameworks/kirigami/-/commit/bdb322527fbc910ce7124a45dc43dfaa0fad1522
--
You are receiving this mail because:
You are watching all bug changes.
