https://bugs.kde.org/show_bug.cgi?id=350779
Marco Martin <notm...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Latest Commit| |http://commits.kde.org/plas
| |ma-desktop/44866deb0261662e
| |afde10fd750def25c17aef91
Resolution|--- |FIXED
--- Comment #6 from Marco Martin <notm...@gmail.com> ---
Git commit 44866deb0261662eafde10fd750def25c17aef91 by Marco Martin.
Committed on 29/09/2016 at 11:06.
Pushed by mart into branch 'master'.
use KPluginSelector to enable runners
Summary:
the configuration dialog for enabling runners by category
was a neat idea but had several problems, gave by it
reinventing the wheel too much.
when changing the locale, the enabled categories list was resetted
due to categories being localized. it was also pretty
difficult to disable a particular plugin as you would have to
know what categoriesyou have to disable.
this approach is more basic, but reusing a common implementation,
we avoid some bugs and misbehaviors.
Test Plan: ran on an existing krunnerrc with different sets of categories
enabled, tested krunner and its kcm with it, all expected runner plugins were
used both in the kcm and while searching with krunner
Reviewers: broulik, #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2872
M +13 -244 kcms/runners/kcm.cpp
M +2 -26 kcms/runners/kcm.h
http://commits.kde.org/plasma-desktop/44866deb0261662eafde10fd750def25c17aef91
--
You are receiving this mail because:
You are watching all bug changes.
