https://bugs.kde.org/show_bug.cgi?id=470219
Fushan Wen <qydwhotm...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi
|t/9d18e0821455366c00a763252 |t/e2ef967c5860543c7c4bf3da9
|515d48741316f6c |129b0c70292e8ed
--- Comment #4 from Fushan Wen <qydwhotm...@gmail.com> ---
Git commit e2ef967c5860543c7c4bf3da9129b0c70292e8ed by Fushan Wen, on behalf of
Max Ramanouski.
Committed on 07/06/2023 at 14:07.
Pushed by fusionfuture into branch 'master'.
runners/calculator: implement thread-safety in QalculateEngine::evaluate
Libqalculate does not seem to support ability to run multiple computations
that are controlled or have timeout set beeing run in the same time.
After the timeout was introduced in QalculateEngine this led to BUG 470219,
which happens when computations are started from multiple threads in the same
time
that "confuses" libqalculate computation thread which leads to crash in
libqalculate code.
To fix that we need to ensure that only one evaluation is running at single
moment of time.
This is done via QalculateLock class that is like QMutexLocker but for
libqalculate.
QalculateLock is implemented with two static mutexes. Mutex s_evalLock is used
to ensure that only one evaluation is running at single moment.
Mutex s_ctrlLock is used to ensure that thread that aborted evaluation will
get to start next evaluation.
(cherry picked from commit 9d18e0821455366c00a763252515d48741316f6c)
M +35 -8 runners/calculator/qalculate_engine.cpp
https://invent.kde.org/plasma/plasma-workspace/-/commit/e2ef967c5860543c7c4bf3da9129b0c70292e8ed
--
You are receiving this mail because:
You are watching all bug changes.
