https://bugs.kde.org/show_bug.cgi?id=463439

--- Comment #5 from caulier.gil...@gmail.com ---
>This makes sense, but only when building locally. 

And here you are wrong: the digiKam unit-test build is managed in the gitlab CI
while developers commit in the source repository. The data are not used only by
developers locally, but also online in gitlab. 

This solution to separate the huge unit test data from the source code is to
reduce the tarball size at release time. This solution was proposed by the KDE
system admins and i'm sure that others huge KDE applications as Krita and
Kdenlive will also take this way in the future.

>When using a distribution build system, such as the ones in use by Debian and 
>Ubuntu where no external sources can be accessed, this is an >impossible 
>situation. These build systems are designed to run the unit tests as designed 
>by the upstream developers for robustness. As far as I >know, all KDE 
>applications are meant to be distributed by distributions, and DigiKam is no 
>different, is it not? 

Of course. But the unit -tests are already processed previously in your CI
automatically while the evolution of the application, this is the main goal.

>If it's no different, then the unit tests should not rely on external sources, 
>as is the case currently.

2 solutions for you: disabling unit tests while building package as we process
unit tests in digiKam CI, or found a solution to open access to external
resources as the git-fs data repository in your build CI. 

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to