https://bugs.kde.org/show_bug.cgi?id=464621
Vlad Zahorodnii <vlad.zahorod...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/kwin/commit/826fb1cb298f |ma/kwin/commit/3a7115f850d2
|baa21d7dea754ca225754c6851a |e5bf6cb195c1e352a42b5f5ee94
|7 |a
--- Comment #2 from Vlad Zahorodnii <vlad.zahorod...@kde.org> ---
Git commit 3a7115f850d2e5bf6cb195c1e352a42b5f5ee94a by Vlad Zahorodnii.
Committed on 23/01/2023 at 14:18.
Pushed by vladz into branch 'cherry-pick-826fb1cb'.
Fix a crash that happens when resizing quick tiled window
QuickTile::setRelativeGeometry() and QuickRootTile::setVerticalSplit() or
QuickRootTile::setHorizontalSplit() can hit recursion when size
constraints start taking effect.
This change reworks how other quick tiles are resized. With the proposed
design, when relative geometry changes, QuickRootTile will notice that
and start resizing other tiles.
When QuickRootTile resizes horizontal or vertical split, it is going to
ignore QuickRootTile::relativeGeometryChanged() signals (m_resizedTile).
It prevents hitting the recursion and makes moving h/v splits more
predictable.
I do think that in order to make the tile design more robust to this
kind of bugs, it's worth splitting geometry in two kinds though - the
one that indicates the preferred geometry (implicitWidth/implicitHeight
in qtquick lingua) and the current geometry, the parent node then
monitors the preferred geometries and updates the current geometries.
(cherry picked from commit 826fb1cb298fbaa21d7dea754ca225754c6851a7)
M +57 -108 src/tiles/quicktile.cpp
M +12 -25 src/tiles/quicktile.h
M +7 -5 src/tiles/tile.cpp
M +3 -3 src/tiles/tile.h
https://invent.kde.org/plasma/kwin/commit/3a7115f850d2e5bf6cb195c1e352a42b5f5ee94a
--
You are receiving this mail because:
You are watching all bug changes.
