https://bugs.kde.org/show_bug.cgi?id=396530

Nicolas Fella <nicolas.fe...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-nm/commit/9b22aa5
                   |                            |48f02ef43f7275ab2f9ffa48bde
                   |                            |8a1ba8
             Status|ASSIGNED                    |RESOLVED

--- Comment #11 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit 9b22aa548f02ef43f7275ab2f9ffa48bde8a1ba8 by Nicolas Fella.
Committed on 18/01/2023 at 23:07.
Pushed by nicolasfella into branch 'master'.

Offload VPN file parsing to NetworkManager

Parsing the file is complex, with many opportunities to get it wrong

We can offload the whole parsing to nm_vpn_editor_plugin_import, which
takes a file name and gives us a connection object

We then can use NM's client API to add that connection

This closely matches what "nmcli connection import" does

M  +1    -6    kcm/kcm.cpp
M  +2    -2    libs/editor/vpnuiplugin.cpp
M  +5    -3    libs/editor/vpnuiplugin.h
M  +53   -0    libs/handler.cpp
M  +3    -0    libs/handler.h
M  +10   -545  vpn/openvpn/openvpn.cpp
M  +10   -185  vpn/vpnc/vpnc.cpp

https://invent.kde.org/plasma/plasma-nm/commit/9b22aa548f02ef43f7275ab2f9ffa48bde8a1ba8

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to