https://bugs.kde.org/show_bug.cgi?id=463309
David Faure <fa...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/fram
| |eworks/kio/commit/adad3bec2
| |1ebbc886f45ec2ae6065d6b6070
| |fa93
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #7 from David Faure <fa...@kde.org> ---
Git commit adad3bec21ebbc886f45ec2ae6065d6b6070fa93 by David Faure, on behalf
of Nicolas Fella.
Committed on 11/01/2023 at 22:43.
Pushed by dfaure into branch 'master'.
Restore old behavior for KFileFilterCombo::setFilter
fb2a2268dbb2033bb8483d9bee63cb11f914573e refactored it to use the newly
introduced KFileFilter
class to parse the input. However, it actually allows input that is not a valid
filter string expression.
For example K3B uses filters like "audio/x-wav |Wave Sound Files", which are
now parsed incorrectly.
Also, contrary to KFileWidget's filter strings slashes were allowed unescapted,
which broke Krita.
K3B's usage of KFileFilterCombo for this is somewhat questionable, but we
should not break it regardless.
Longer-term setFilter should be replaced with API that takes a KFileFilter
object to avoid such confusion
Revert the implementation of setFilter to the original one. For setMimeFilter
the usage of KFileFilter is fine.
That means we now have separate codepaths for when setFilter and setMimeFilter
was called. Longer-term there will
be only one using KFileFilter
M +20 -0 autotests/kfilefiltercombotest.cpp
M +45 -19 src/filewidgets/kfilefiltercombo.cpp
https://invent.kde.org/frameworks/kio/commit/adad3bec21ebbc886f45ec2ae6065d6b6070fa93
--
You are receiving this mail because:
You are watching all bug changes.
