[plasmashell] [Bug 462980] In Panel Edit Mode, "Maximize" button is inappropriately enabled while Panel is already maximized

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=462980

--- Comment #7 from Nate Graham <n...@kde.org> ---
This seems like it should work:


diff --git
a/desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
b/desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
index 8469bb803..87ed41eaf 100644
---
a/desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
+++
b/desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
@@ -175,6 +175,7 @@ PlasmaCore.Dialog {
             Layout.fillWidth: true
             text: i18nd("plasma_shell_org.kde.plasma.desktop", "Maximize
Panel")
             icon.name: panel.formFactor === PlasmaCore.Types.Vertical ?
"zoom-fit-height" : "zoom-fit-width"
+            enabled: panel.length < panel.maximumLength
             onClicked: panel.maximize();
         }
         PC3.CheckBox {


But it doesn't; the button is either always enabled or always disabled for me.
It seems like panel.maximumLength always returns the actual screen edge length,
but panel.length's actual length often doesn't match that when it's
non-maximized, and does when it's not.

Niccolò, any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.