https://bugs.kde.org/show_bug.cgi?id=428560
Igor Kushnir <igor...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.11.230400
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://invent.kde.org/kdev
| |elop/kdevelop/commit/77e503
| |c74a3ef5fbf3b163da4a0e71b6a
| |9255bce
--- Comment #2 from Igor Kushnir <igor...@gmail.com> ---
Git commit 77e503c74a3ef5fbf3b163da4a0e71b6a9255bce by Igor Kushnir.
Committed on 27/12/2022 at 09:24.
Pushed by igorkushnir into branch 'master'.
RunController: ignore projectConfigurationChanged signal
No settings within the Configure Project dialog affect launch
configurations. So no need to reread the configs and recreate the
launches and their actions. I suppose project configuration did affect
launch configurations in the past, but I don't see this in current code.
Project target combobox on the native app config page and available
targets in suggestion submenus of "Add a new launch configuration"
button are populated when a Launch Configurations dialog is created
(each time it is shown).
Since 62ae1929c5a5d1a6a200a07579a4cca635cd9364 the
projectConfigurationChanged signal is also emitted when a CMake import
job finishes without error. This was done for the benefit of
CompilerProvider and is useless to RunController. The same argument
applies to emitting this signal when a Meson import job finishes without
error (the code has been copied from cmake plugin to meson plugin).
Recreating the launches and their actions caused a crash when a folder
that contained a target was excluded (filtered out) from the project and
the Launch Configurations dialog with this target as the Project target
of an existing configuration was shown before the CMake import job
finished:
#0 KDevelop::LaunchConfigurationsModel::data() at
kdevelop/kdevplatform/shell/launchconfigurationdialog.cpp:611
#1 QStyledItemDelegate::initStyleOption(QStyleOptionViewItem*, QModelIndex
const&) const() at /usr/lib/libQt5Widgets.so.5
#2 QStyledItemDelegate::paint(QPainter*, QStyleOptionViewItem const&,
QModelIndex const&) const() at /usr/lib/libQt5Widgets.so.5
#3 QTreeView::drawRow(QPainter*, QStyleOptionViewItem const&, QModelIndex
const&) const() at /usr/lib/libQt5Widgets.so.5
#4 QTreeView::drawTree(QPainter*, QRegion const&) const() at
/usr/lib/libQt5Widgets.so.5
#5 QTreeView::paintEvent(QPaintEvent*)() at /usr/lib/libQt5Widgets.so.5
FIXED-IN: 5.11.230400
M +0 -8 kdevplatform/shell/runcontroller.cpp
M +0 -1 kdevplatform/shell/runcontroller.h
https://invent.kde.org/kdevelop/kdevelop/commit/77e503c74a3ef5fbf3b163da4a0e71b6a9255bce
--
You are receiving this mail because:
You are watching all bug changes.
