https://bugs.kde.org/show_bug.cgi?id=423524
David Edmundson <k...@davidedmundson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED Latest Commit| |https://invent.kde.org/plas | |ma/plasma-workspace/commit/ | |28560c5d1c2e3a22593c716b399 | |e73cb3e27f32f --- Comment #3 from David Edmundson <k...@davidedmundson.co.uk> --- Git commit 28560c5d1c2e3a22593c716b399e73cb3e27f32f by David Edmundson. Committed on 15/09/2022 at 15:55. Pushed by davidedmundson into branch 'master'. [applets/kickoff] Always instantiate KService::Ptr member Code uses m_service unconditionally in many branches, it is exposed as public API. Given KService is a data class with an isValid method, it's clearer to ensure that KService::Ptr always returns a valid object which in turn can then be valid rather than having two paths for the same goal. This can be relevant in a situation where an entry using the "preferred" schema references an entry that doesn't exist. M +7 -5 applets/kicker/plugin/appentry.cpp https://invent.kde.org/plasma/plasma-workspace/commit/28560c5d1c2e3a22593c716b399e73cb3e27f32f -- You are receiving this mail because: You are watching all bug changes.