https://bugs.kde.org/show_bug.cgi?id=456550
ratijas <m...@ratijas.tk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/fram
| |eworks/plasma-framework/com
| |mit/d202dc7fda5b182528a0da1
| |1fa549d86df52a8ba
Status|ASSIGNED |RESOLVED
--- Comment #5 from ratijas <m...@ratijas.tk> ---
Git commit d202dc7fda5b182528a0da11fa549d86df52a8ba by ivan tkachenko.
Committed on 14/09/2022 at 13:17.
Pushed by ratijas into branch 'master'.
PC3/ProgressBar: Fix sizing bugs, reformat code, remove animation hacks
This patch makes implementation both simpler and more robust at once.
Parts of sizing expressions were copied from the Slider component, but
adjusted for horizontal-only and legally-zero-progress usecase.
Fixed potentially undefined properties access for `fixedMargins` in Item
context (a bug which is not reproducible with any of the stock themes,
as they all provide size hints in their SVG).
Finally, the indeterminate animation was rewritten almost from scratch,
so now an SVG item is properly animated from side to side, without going
out of bound nor being unable to hit the farmost position. And it even
handles mid-flight control resizing pretty well!
PS That `children[0].height` is a bit of an iffy hack. But introducing
id to the inner component would prevent engine from optimizing the
whole tree away when the background property is overridden. And using
`childrenRect.height` results in binding loops because childrenRect
(being a grouped property) updates for any geometry change. Ideally, I
would factor it all out in a private/DefaultProgressBarBackground.qml,
so that we could straight use an id, and don't worry about missing an
optimization opportunity.
M +47 -40 src/declarativeimports/plasmacomponents3/ProgressBar.qml
https://invent.kde.org/frameworks/plasma-framework/commit/d202dc7fda5b182528a0da11fa549d86df52a8ba
--
You are receiving this mail because:
You are watching all bug changes.
