https://bugs.kde.org/show_bug.cgi?id=449005

NSLW <lukasz.wojnilow...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
            Version|5.89.0                      |5.86.0

--- Comment #4 from NSLW <lukasz.wojnilow...@gmail.com> ---
I think it's not a downstream issue anymore. Line chart graphs worked on
kquickcharts v5.85.0 and stopped on v5.86.0.  My regression test gave following
result. Please fix it.

00637f36bdedd2513a6264b3d1952d61c12bf312 is the first bad commit
commit 00637f36bdedd2513a6264b3d1952d61c12bf312
Author: Arjen Hiemstra <ahiems...@heimr.nl>
Date:   Mon Aug 23 17:54:26 2021 +0200

    Implement batching for Line chart material

    This allows line chart segments and the respective material to be
    batched, by sending per-segment data as vertex attributes rather than
    uniforms.

    Unfortunately, OpenGL 2.1/GLSL 1.10 doesn't support array vertex
    attributes, so instead this emulates an array by simply defining a bunch
    of vertex attributes and manually converting it to an output array.

 src/scenegraph/LineChartMaterial.cpp | 110 +++++++------------------
 src/scenegraph/LineChartMaterial.h   |  33 +-------
 src/scenegraph/LineChartNode.cpp     |   6 +-
 src/scenegraph/LineSegmentNode.cpp   | 153 +++++++++++++++++++++++++++--------
 src/scenegraph/LineSegmentNode.h     |   4 +-
 src/shaders/linechart.frag           |  33 ++++----
 src/shaders/linechart.vert           |  69 ++++++++++++++--
 7 files changed, 239 insertions(+), 169 deletions(-)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to