https://bugs.kde.org/show_bug.cgi?id=456917
Nicolas Fella <nicolas.fe...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
|ities/yakuake/commit/35bed3 |ities/yakuake/commit/255172
|5bb88c12121502a515172e33ad9 |5589e6b748e3c2a49452ac44e05
|a037823 |25e5736
--- Comment #4 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit 2551725589e6b748e3c2a49452ac44e0525e5736 by Nicolas Fella.
Committed on 22/08/2022 at 20:26.
Pushed by nicolasfella into branch 'master'.
Revise ownership of terminal instances
Currently the Terminal objects are parented to the base splitter
When they are destroyed the session reacts to that and removes them from its
internal map
This is rather complex and causes a crash when closing the app
Instead have the session own the terminals (and manage them using unique_ptr)
This is complicated by the fact that the part instance deletes itself when the
terminal is exited by the user
In that case notify the session that the terminal wants to be deleted and clean
up accordingly
M +37 -35 app/session.cpp
M +1 -1 app/session.h
M +16 -12 app/terminal.cpp
M +3 -0 app/terminal.h
https://invent.kde.org/utilities/yakuake/commit/2551725589e6b748e3c2a49452ac44e0525e5736
--
You are receiving this mail because:
You are watching all bug changes.
