https://bugs.kde.org/show_bug.cgi?id=425202
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Version Fixed In| |22.12
Latest Commit| |https://invent.kde.org/netw
| |ork/kdenetwork-filesharing/
| |commit/8a37b42000c56a23c8c8
| |3617f4f4406b370e5551
Status|ASSIGNED |RESOLVED
--- Comment #10 from Nate Graham <n...@kde.org> ---
Git commit 8a37b42000c56a23c8c83617f4f4406b370e5551 by Nate Graham.
Committed on 05/08/2022 at 14:33.
Pushed by ngraham into branch 'master'.
Make initial setup much clearer
There are a lot of ways that initial Samba sharing setup can go wrong if
the distro hasn't set up everything perfectly out of the box. Right now
the wizard shows some error messages when problems are encountered, but
the logic fails to account for the full set of things that can go wrong
during initial setup, and as a result are sometimes displays misleading
error messages that can send the user down the wrong path.
This commit expands the set of conditions that are checked for, and
offers more verbose and actionable error messages specific to each of
them.
To accomplish this, the code is refactored to move nearly all of the
logic to the backend, with the QML side simply presenting the
information for whatever error was encountered.
The existing code already had logic for showing a friendly button to fix
the "you're not a member of the right group" error condition, which is
preserved here. TODOs are added in the place where other similar actions
to fix the other errors could be defined, which can be done later.
FIXED-IN: 22.12
M +81 -58 samba/filepropertiesplugin/groupmanager.cpp
M +26 -17 samba/filepropertiesplugin/groupmanager.h
M +12 -19 samba/filepropertiesplugin/qml/GroupPage.qml
https://invent.kde.org/network/kdenetwork-filesharing/commit/8a37b42000c56a23c8c83617f4f4406b370e5551
--
You are receiving this mail because:
You are watching all bug changes.
