https://bugs.kde.org/show_bug.cgi?id=455956
Bug ID: 455956
Summary: ksambashare.cpp -- username regex is way too
restrictive.
Product: frameworks-kio
Version: 5.95.0
Platform: Gentoo Packages
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: kio-bugs-n...@kde.org
Reporter: hims...@claus-justus-heine.de
CC: kdelibs-b...@kde.org
Target Milestone: ---
Created attachment 150163
--> https://bugs.kde.org/attachment.cgi?id=150163&action=edit
Patch fixing the issue.
SUMMARY
Username regexp in src/core/ksambashare.cpp is wrong, only word characters are
accepted which excudes things like firstname.lastname, or foo-bar for
first_second.
According
https://docs.microsoft.com/en-us/previous-versions//cc722458(v=technet.10)?redirectedfrom=MSDN
only " / \ [ ] : ; | = , + * ? < > are disallowed characters. The attached
patch tries to fix this.
STEPS TO REPRODUCE
1. Add a user to the system and Samba with a "special" character, like foo.bar
2. Try to create a Samba-share in e.g. Dolphin
3. This will fail, as the generated regexp does not pass
KSambaSharePrivate::isAclValid()
OBSERVED RESULT
Share is not updated
EXPECTED RESULT
Share is updated
SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Gentoo / X11
KDE Plasma Version: 5.25.1
KDE Frameworks Version: 5.95.0
Qt Version: 5.18.6
ADDITIONAL INFORMATION
The bug is still present in the master branch.
--
You are receiving this mail because:
You are watching all bug changes.
