https://bugs.kde.org/show_bug.cgi?id=455644

Frédéric Brière <fbri...@fbriere.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/choqok/commit/27fd8ef86
                   |                            |b98b0062f3488a3563091ac9afd
                   |                            |fe70

--- Comment #4 from Frédéric Brière <fbri...@fbriere.net> ---
Git commit 27fd8ef86b98b0062f3488a3563091ac9afdfe70 by Frédéric Brière.
Committed on 21/06/2022 at 13:59.
Pushed by scarpino into branch 'master'.

Disconnect self-connected signals emitted from a parent class

Signals connected from an object to itself should be disconnected in the
dtor if said signal is emitted from the parent class.  Otherwise, if
that signal ends up being emitted in the parent dtor, it will attempt to
invoke a method on the now-destroyed child object.

(In all fairness, only one of these connections, namely the one to
TextEdit::textChanged(), is actually problematic, as all others fall
into the "you can no longer click on stuff at this point anyway"
category.  Still, better safe than sorry.)

M  +2    -0    choqok/mainwindow.cpp
M  +4    -0    libchoqok/ui/choqoktextedit.cpp
M  +1    -0    plugins/betternotify/dummynotification.cpp

https://invent.kde.org/network/choqok/commit/27fd8ef86b98b0062f3488a3563091ac9afdfe70

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to