https://bugs.kde.org/show_bug.cgi?id=455367
Bug ID: 455367
Summary: Vertical unreadable `% Complete` progress bars
Product: ktorrent
Version: 5.1
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: joris.guis...@gmail.com
Reporter: danails...@gmail.com
Target Milestone: ---
Created attachment 149761
--> https://bugs.kde.org/attachment.cgi?id=149761&action=edit
unreadable vertical progress bars
Hello,
After bumping KDE plasma to 5.25 on my Gentoo system I noticed that the `%
Complete` column contains a vertical progress bar (see screenshots of when a
torrent entry has been selected and not selected attached). On both screenshots
the progress bar is supposed to show "71%"
>From my point of view such a progress bar is quite unusable as
* the bar is quite thin and hard to spot
* it misses the numeric value of the percentage, therefore one cannot easily
figure out whether the torrent is almost completed (at e.g. 99.5%), or
completely completed
* when the new "Colour from current wallpaper" plasma feature is enabled, it is
hard to see where the progress is up to as the colours of the "full" and
"empty" bits are quite similar (though this is not a KTorrent issue, I assume)
I cannot imagine why one would want a vertical progress bar in the context of a
table of torrents, but I could also imagine that this has been an incompatible
upstream (e.g. Qt) change in the controls default state. Anyway, I have applied
the following naive patch onto master to bring horizontal progress bars with
numeric value back:
```
diff --git a/ktorrent/view/viewdelegate.cpp b/ktorrent/view/viewdelegate.cpp
index 8de17708..88b4c058 100644
--- a/ktorrent/view/viewdelegate.cpp
+++ b/ktorrent/view/viewdelegate.cpp
@@ -325,7 +325,7 @@ void ViewDelegate::paintProgressBar(QPainter *painter,
const QStyleOptionViewIte
QStyleOptionProgressBar progressBarOption;
progressBarOption.palette = option.palette;
- progressBarOption.state = option.state;
+ progressBarOption.state = option.state |
QStyle::StateFlag::State_Horizontal;
progressBarOption.rect = option.rect;
progressBarOption.minimum = 0;
progressBarOption.maximum = 100;
```
I would be happy to see horizontal progress bars back in the next release, even
if hidden behind some configuration.
My system:
```
Operating System: Gentoo Linux 2.8
KDE Plasma Version: 5.25.0
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.4
Kernel Version: 5.15.41-gentoo-x86_64 (64-bit)
Graphics Platform: X11
Processors: 16 × AMD Ryzen 7 1800X Eight-Core Processor
Memory: 31.3 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 1070/PCIe/SSE2
```
Danail
--
You are receiving this mail because:
You are watching all bug changes.
