https://bugs.kde.org/show_bug.cgi?id=453948

Dmitry Kazakov <dimul...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dimul...@gmail.com

--- Comment #4 from Dmitry Kazakov <dimul...@gmail.com> ---
Hi, amyspark!

Usually we use selections in the following way: 

1) Copy selected pixels out of the source device into an empty device using
COMPOSITE_OVER (or COMPOSITE_COPY) and a selection.
2) Erase the selection on the source device (with clearSelection()).
3) Transform the pixels on the separate device
4) Copy transformed pixels back into the source device using COMPOSITE_OVER (or
COMPOSITE_COPY) blendmode

As far as I can tell, KisImageInterface::gmic_qt_get_cropped_images() skips
point 2), therefore there are leftovers left on the device.

PS:
Theoretically, we could use the blending method of the layer styles. It works
better in some cases and avoids generation of halos. Though I'm not totally
sure it'll work correctly in this particular case, when the cut piece can be
transformed. The layer style's blending method is implemented in
`KisLayerStyleProjectionPlane::apply`.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to