https://bugs.kde.org/show_bug.cgi?id=445955
Nicolas Fella <nicolas.fe...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/netw
| |ork/kdeconnect-android/comm
| |it/8f49ff57ab43961bea65cddd
| |35b250f7f5301567
Resolution|--- |FIXED
--- Comment #2 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit 8f49ff57ab43961bea65cddd35b250f7f5301567 by Nicolas Fella, on behalf
of Ravi Mistry.
Committed on 30/05/2022 at 21:28.
Pushed by nicolasfella into branch 'master'.
Fix byte array conversions
## Summary
Currently, KDE Connect for Android doesn't show the last 2 characters of the
verification key when pairing a device. This MR solves this issue.
This bug is caused by incomplete conversions from byte arrays to strings in
`SslHelper.java`:
```java
for (int i = 0; i < hash.length - 1; i++) {
formatter.format("%02x", hash[i]);
}
```
The ```i < hash.length -1``` converts the bytes in the array up to (inclusive)
the penultimate one. Removing the ```- 1``` allows for the last byte to be
converted (this is the missing 2 characters).
## Test Plan
### Before:
Selecting a desktop from the available devices, then clicking the `Request
Pairing` button causes a 62 character key to be displayed. It is 2 characters
short of the actual key, which can be seen on the desktop KDE Connect app.
### After:
Selecting the `Request Pairing` button now shows the whole verification key, as
intended.
M +2 -2 src/org/kde/kdeconnect/Helpers/SecurityHelpers/SslHelper.java
https://invent.kde.org/network/kdeconnect-android/commit/8f49ff57ab43961bea65cddd35b250f7f5301567
--
You are receiving this mail because:
You are watching all bug changes.
