https://bugs.kde.org/show_bug.cgi?id=448064

Vlad Zahorodnii <vlad.zahorod...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/kwin/commit/4c3195270d6c
                   |                            |8e1da8c3e2e3abe5aae75d5bf3c
                   |                            |2
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #18 from Vlad Zahorodnii <vlad.zahorod...@kde.org> ---
Git commit 4c3195270d6c8e1da8c3e2e3abe5aae75d5bf3c2 by Vlad Zahorodnii.
Committed on 21/05/2022 at 11:03.
Pushed by merge-service into branch 'Plasma/5.24'.

Ensure that Toplevel::output() stays always in sync with geometry

Currently, if geometry updates are blocked, the Toplevel.output property
won't be updated. On the other hand, it's reasonable to use the output
property instead of manually looking up the output in window management
code, e.g. Workspace::clientArea().

In other words, using the Toplevel.output property is like walking on a
mine field, things can blow up. You can't use Toplevel.output even if it
makes perfect sense.

This change ensures that Toplevel.output property is always kept in sync
with the frame geometry. Unfortunately, this means that the output
property no longer can be updated when the frameGeometryChanged() signal
is emitted. It has to be done in moveResizeInternal() method.

(cherry picked from 510a41eeb89f51843405fa0258c852ab06d05bb8)

Part-of: <https://invent.kde.org/plasma/kwin/-/merge_requests/2448>

M  +0    -3    src/abstract_client.cpp
M  +1    -0    src/events.cpp
M  +6    -0    src/internal_client.cpp
M  +0    -17   src/toplevel.cpp
M  +2    -8    src/toplevel.h
M  +6    -0    src/unmanaged.cpp
M  +1    -0    src/unmanaged.h
M  +6    -0    src/waylandclient.cpp
M  +7    -0    src/x11client.cpp
M  +1    -0    src/x11client.h

https://invent.kde.org/plasma/kwin/commit/4c3195270d6c8e1da8c3e2e3abe5aae75d5bf3c2

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to